-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix show route map JSON display #14856
Conversation
@Mergifyio backport stable/9.1 stable/9.0 stable/8.5 |
✅ Backports have been created
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of chips (non-blocking) from my side :)
Move the command from 'lib' to 'vtysh' so we can properly format the JSON output in a correct manner. Signed-off-by: Rafael Zalamena <[email protected]>
Remove zebra duplicated command documentation without description. Signed-off-by: Rafael Zalamena <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
lib: fix show route map JSON display (backport #14856)
lib: fix show route map JSON display (backport #14856)
lib: fix show route map JSON display (backport #14856)
Fixes #13515 .
This PR moves the
show route-map
daemon output aggregation tovtysh
so we can properly format the JSON output. It also removes azebra
lingering documentation that duplicates the one found inroute-map
docs.