zebra: remove proto nhid from system, when NHG_DEL is sent #14946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When suppressing a nexthop group, the proto nhid is still present in the system: > ubuntu2204(config)# nexthop-group LL > 2023/12/04 21:23:44 SHARP: [Q5NBA-GN1BG] NHG ID assigned: 179687510 > ubuntu2204(config-nh-group)# nexthop 192.0.2.43 loop1 > ubuntu2204(config-nh-group)# no nexthop 192.0.2.43 loop1 > 2023/12/04 21:23:56 ZEBRA: [RY75W-058E9] zebra_nhg_proto_del: deleted nhe 0x55edc18eb870 (179687510[260]), vrf 0, type sharp > 2023/12/04 21:23:56 ZEBRA: [WDEB1-93HCZ] zebra_nhg_decrement_ref: nhe 0x55edc18eb870 (179687510[260]) 1 => 0 > 2023/12/04 21:23:56 SHARP: [H3QKG-WH8ZV] Removed nhg 179687510 > ubuntu2204(config-nh-group)# > ubuntu2204(config-nh-group)# exi > ubuntu2204(config)# <Ctrl-D> > # ip nexthop ls > id 179687510 group 260 proto 194 > id 260 via 192.0.2.43 dev loop1 scope link proto 194 There is no need to keep nexthop group from protocol levels if there are no references to that nexthop group. Fix this by forcing the system removal only if it is a protocol nhid. Fixes: 35729f3 ("zebra: Add a timer to nexthop group deletion") Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
nhg_proto_delete
branch
from
859b0dc to
05ca03f
Compare
|
I really don't see the point of this. The code that keeps nexthop groups around for a specified amount of time is working as intended. What meta problem are you fixing? |
|
you are right. I did not see the 'zebra nexthop keep' command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When suppressing a nexthop group, the proto nhid is still present in the system:
There is no need to keep nexthop group from protocol levels if there are no references to that nexthop group. Fix this by forcing the system removal only if it is a protocol nhid.
Fixes: 35729f3 ("zebra: Add a timer to nexthop group deletion")