ospfd: fix some ospf cmds' param range #15014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Shbinging
commented
Dec 13, 2023
•
Shbinging
commented
- fix ip ospf dead-interval minimal hello-multiplier param range (2-20) accroding to OSPFv2 doc(ospfd.rst)
- add param range of graceful-restart helper supported-grace-time in OSPFv2 doc(ospfd.rst)
- check other cmds' param range
Signed-off-by: Bing Shui <[email protected]>
Signed-off-by: Bing Shui <[email protected]>
|
Which one is correct: the doc or the CLI? 😄 |
|
well a dead interval hello multiplier of 1 makes no sense. It would effectively imply that OSPF would declare the peering dead at the same time it's supposed to send a hello |
|
@Mergifyio backport stable/9.1 stable/9.0 stable/8.5 |
✅ Backports have been created
|
This was referenced Dec 14, 2023
donaldsharp
added a commit
that referenced
this pull request
Dec 14, 2023
ospfd: fix some ospf cmds' param range (backport #15014)
donaldsharp
added a commit
that referenced
this pull request
Dec 14, 2023
ospfd: fix some ospf cmds' param range (backport #15014)
donaldsharp
added a commit
that referenced
this pull request
Dec 14, 2023
ospfd: fix some ospf cmds' param range (backport #15014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.