tests: bfd_vrf_ospf_unnumbered #15048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test that runs dynamic BFD sessions in a VRF over OSPF unnumbered interfaces. OSPF metric is different on each interface to make sure BFD packets are sent on the correct interface. This test currently fails as there appears to be a bug in OSPF not setting interface option with dynamic BFD. Signed-off-by: Lynne Morrison <[email protected]>
ton31337
requested changes
Dec 22, 2023
| [ | ||
| { | ||
| "multihop":false, | ||
| "peer":"2.2.2.2", |
There was a problem hiding this comment.
Please use https://www.rfc-editor.org/rfc/rfc5737.html ranges or private ranges for topotests.
| }, | ||
| { | ||
| "multihop":false, | ||
| "peer":"3.3.3.3", |
| ! | ||
| hostname r1 | ||
| password zebra | ||
| log file /tmp/r1-frr.log |
| log file /tmp/r1-frr.log | ||
| ! | ||
| interface Test | ||
| ip address 1.1.1.1/32 |
| @@ -0,0 +1,16 @@ | |||
| VRF Name: Test | |||
|
|
||
| # Required to instantiate the topology builder class. | ||
|
|
||
| pytestmark = [pytest.mark.ospfd, pytest.mark.bgpd] |
|
|
||
|
|
||
| def setup_module(mod): | ||
| logger.info("OSPF Multi VRF Topology with BGP route leaking:\n {}".format(TOPOLOGY)) |
| router.load_frr_config(os.path.join(CWD, "{}/frr.conf".format(rname))) | ||
|
|
||
| router.load_config( | ||
| TopoRouter.RD_BFD, os.path.join(CWD, "{}/bfdd.conf".format(rname)) |
There was a problem hiding this comment.
Can't we just bundle this with frr.conf?
|
|
||
| # Initialize all routers. | ||
| tgen.start_router() | ||
| for router in router_list.values(): |
| tgen = get_topogen() | ||
|
|
||
| if tgen.routers_have_failure(): | ||
| pytest.skip("skipped because of router(s) failure") |
There was a problem hiding this comment.
Do we want to skip or raise an error on failures?
|
Closing per authors request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test that runs dynamic BFD sessions in a VRF over OSPF
unnumbered interfaces. OSPF metrics are different on each
interface to make sure BFD packets are sent on the correct
interface.
This test currently fails as there appears to be a bug in OSPF not
setting interface option with dynamic BFD.