Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redhat: rpm spec: added protobuf-c to deps & fix bogus changelog date #15054

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

k0ste
Copy link
Contributor

@k0ste k0ste commented Dec 21, 2023

Fixes for:

checking for protoc-c... no
configure: error: in `/builddir/build/BUILD/frr-frr-9.1':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.

And rpmlint warnings:

warning: line 208: It's not recommended to have unversioned Obsoletes: Obsoletes:          gated mrt zebra frr-sysvinit
warning: bogus date in %changelog: Thu Oct 09 2023 Donatas Abraitis <donatas@opensourcerouting.org> - 9.1
    line 208: It's not recommended to have unversioned Obsoletes: Obsoletes:          gated mrt zebra frr-sysvinit
    bogus date in %changelog: Thu Oct 09 2023 Donatas Abraitis <donatas@opensourcerouting.org> - 9.1

redhat/frr.spec.in Outdated Show resolved Hide resolved
@ton31337
Copy link
Member

Also, could you change the prefix of the commit to redhat: ?

Fixes for:
```
checking for protoc-c... no
configure: error: in `/builddir/build/BUILD/frr-frr-9.1':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
```

And rpmlint warnings:
```
warning: line 208: It's not recommended to have unversioned Obsoletes: Obsoletes:          gated mrt zebra frr-sysvinit
warning: bogus date in %changelog: Thu Oct 09 2023 Donatas Abraitis <[email protected]> - 9.1
    line 208: It's not recommended to have unversioned Obsoletes: Obsoletes:          gated mrt zebra frr-sysvinit
    bogus date in %changelog: Thu Oct 09 2023 Donatas Abraitis <[email protected]> - 9.1
```

Signed-off-by: Konstantin Shalygin <[email protected]>
@frrbot frrbot bot added the packaging label Dec 22, 2023
@k0ste k0ste changed the title RPM spec: added protobuf-c to deps & fix bogus changelog date redhat: rpm spec: added protobuf-c to deps & fix bogus changelog date Dec 22, 2023
@k0ste
Copy link
Contributor Author

k0ste commented Dec 22, 2023

Also, could you change the prefix of the commit to redhat: ?

Done

@ton31337 ton31337 merged commit 4d29c17 into FRRouting:master Jan 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants