Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: take into account the Linux IFF_LOWER_UP flag #15082

Merged
merged 4 commits into from
May 28, 2024

zebra: fix fpm_listener compilation

bb46027
Select commit
Loading
Failed to load commit list.
Merged

lib: take into account the Linux IFF_LOWER_UP flag #15082

zebra: fix fpm_listener compilation
bb46027
Select commit
Loading
Failed to load commit list.
frrbot / frrbot completed Apr 26, 2024 in 11s

Style and/or linter errors found

Style and/or linter errors found

Details

Thanks for your contribution to FRR!

Click for style suggestions

diff --git a/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py b/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py
index 85f08e1a3..59afc7a8a 100644
--- a/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py
+++ b/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py
@@ -634,7 +634,7 @@ def test_ospf_show_p1(request):
 
     # show ip ospf route
     ip = topo["routers"]["r0"]["links"]["r3"]["ipv4"]
-    ip_net = str(ipaddress.ip_interface(u"{}".format(ip)).network)
+    ip_net = str(ipaddress.ip_interface("{}".format(ip)).network)
     nh = topo["routers"]["r0"]["links"]["r1"]["ipv4"].split("/")[0]
     input_dict = {
         "r1": {"static_routes": [{"network": ip_net, "no_of_ip": 1, "routeType": "N"}]}

To apply the style suggestions:

curl https://gist.githubusercontent.com/polychaeta/eeb17475b7cfad87f0b29a0da9788283/raw/683d18e0f670bccc69a8f858ba4184180530b04f/style.diff | git apply -

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.