*: fix 'show nexthop-group rib' displays invalid VRF #15084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring a VRF route with a nexthop group, the nexthop group displays a wrong VRF: > ubuntu2204(config)# nexthop-group A > ubuntu2204(config-nh-group)# nexthop 172.31.0.100 > ubuntu2204(config-nh-group)# end > ubuntu2204# sharp install routes vrf vrf3 2.2.2.0 nexthop-group A 1 > ubuntu2204# show ip route vrf vrf3 nexthop-group > [..] > D>* 2.2.2.0/32 [150/0] (633) via 172.31.0.100, loop3 (vrf default), weight 1, 00:00:07 > ubuntu2204# show nexthop-group rib 633 > [..] > VRF: default > [..] Fix this by using the vrf_id of the route that uses the nexthop-group. Also, when NHG_ADD is used, the zapi_nhg structure hosts the vrf_id value. The displayed VRF value is only a consistency change, and does not prevent an user to attach two different routes from different VRFs with the same NHG. It is up to the CP daemon to ensure routes are using the appropriate NHG. Fixes: df9069c ("zebra: Add some more output to show nexthop-group") Signed-off-by: Philippe Guibert <[email protected]>
|
I disagree that this is a bug: if you want the nexthop to be in a different vrf you must specify it. |
|
With this change I can now no longer have nexthops into multiple vrfs using the nexthop-group syntax and the nexthops are forced to be in the vrf that the route is being installed into. |
does that mean that nhe->vrf_id can be suppressed? |
|
closing this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring a VRF route with a nexthop group, the nexthop group displays a wrong VRF:
Fix this by using the vrf_id of the route that uses the nexthop-group. Also, when NHG_ADD is used, the zapi_nhg structure hosts the vrf_id value.
The displayed VRF value is only a consistency change, and does not prevent an user to attach two different routes from different VRFs with the same NHG. It is up to the CP daemon to ensure routes are using the appropriate NHG.
Fixes: df9069c ("zebra: Add some more output to show nexthop-group")