Lib zebra h cleanup #15092
Merged
Lib zebra h cleanup #15092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only 2 places sendmmsg is used is in zlog_5424.c and zlog_live.c. Why is the rest of the entire system paying for this compilation? Signed-off-by: Donald Sharp <[email protected]>
Only a couple of places use this. Move these to a better spot. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
The rfapi code was not using the zlog_backtrace() functionality. Let's just convert over to using the proper functionality that we have built in now. Signed-off-by: Donald Sharp <[email protected]>
The backtrace functionality has been abstracted over to zlog_backtrace(). Now that every place uses this move the inclusion for HAVE_GLIBC_BACKTRACE into the appropriate files instead of having everyone pay for this costly include. Signed-off-by: Donald Sharp <[email protected]>
All modern systems should have these defined. Let's stop paying the cost of this compilation. Signed-off-by: Donald Sharp <[email protected]>
This file inclusion is only used in 3 places move the includes to those spots. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Practically no-one uses this and ioctls are pretty much wrappered. Further wrappering could make this even better. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
lib_zebra_h_cleanup
branch
from
98c6e06 to
fa3d8de
Compare
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
lib_zebra_h_cleanup
branch
from
fa3d8de to
496d87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zebra.h has become a bit of a dumping ground for system headers. Let's make a single pass through zebra.h and properly locate stuff where it belongs. Especially for includes that are only used by 1-2 files.
Initial results of compile time on my machine actually surprised me.
I run a make -j32
Before timings:
After Timings: