Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib zebra h cleanup 2 #15098

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Conversation

donaldsharp
Copy link
Member

Second round.

Before:

Executed in   11.94 secs    fish           external
   usr time  169.24 secs    0.00 micros  169.24 secs
   sys time   52.49 secs  628.00 micros   52.48 secs

After:

Executed in   11.85 secs    fish           external
   usr time  166.39 secs  379.00 micros  166.39 secs
   sys time   50.87 secs  206.00 micros   50.87 secs

More time saved in usr time and sys, starting to hit diminishing returns on actual wall clock time for me.

@ton31337
Copy link
Member

ton31337 commented Jan 6, 2024

Seems we have some issues yet with the compilation.

@donaldsharp donaldsharp force-pushed the lib_zebra_h_cleanup_2 branch from 7507b05 to 644bc91 Compare January 6, 2024 15:50
@github-actions github-actions bot added size/L and removed size/M labels Jan 6, 2024
@choppsv1 choppsv1 self-requested a review January 7, 2024 14:50
@donaldsharp donaldsharp force-pushed the lib_zebra_h_cleanup_2 branch from 644bc91 to 7507b05 Compare January 7, 2024 17:35
@github-actions github-actions bot added size/M and removed size/L labels Jan 7, 2024
@donaldsharp donaldsharp force-pushed the lib_zebra_h_cleanup_2 branch from 7507b05 to c9bbbc3 Compare January 8, 2024 19:01
@github-actions github-actions bot added size/L and removed size/M labels Jan 8, 2024
@donaldsharp donaldsharp force-pushed the lib_zebra_h_cleanup_2 branch from c9bbbc3 to 7e195e6 Compare January 9, 2024 17:43
@donaldsharp donaldsharp force-pushed the lib_zebra_h_cleanup_2 branch from 7e195e6 to c402a0b Compare January 9, 2024 17:50
@ton31337 ton31337 merged commit 67e8ef2 into FRRouting:master Jan 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants