Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib, vtysh: Drop terminal no length cmd #15107

Closed

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Jan 7, 2024

It's deprecated long time ago, let's just drop it.

It's deprecated long time ago, let's just drop it.

Signed-off-by: Donatas Abraitis <[email protected]>
@donaldsharp
Copy link
Member

I'm actually a bit confused. Current behavior is to set vty->lines = -1 on vty creation. This implies a default of terminal no length. If the operator were to specify a terminal length between 0 and 512 FRR would set this value and the only way to go back to this behavior would be to enter the line of terminal no length. How is this deprecated?

@ton31337
Copy link
Member Author

ton31337 commented Jan 8, 2024

You can set "terminal length 0", it's the same, right?

@donaldsharp
Copy link
Member

The code is treating 0 and -1 as different, right?

@ton31337
Copy link
Member Author

ton31337 commented Jan 8, 2024

Then I don't understand why this command is under deprecation...

@ton31337 ton31337 closed this Jan 8, 2024
@ton31337 ton31337 deleted the fix/drop_hidden_cmd branch January 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants