Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add mgmtd to the official pytest.mark list #15119

Merged
merged 1 commit into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/topotests/grpc_basic/test_basic_grpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
GRPCP_PIMD = 50056

pytestmark = [
# pytest.mark.mgmtd -- Need a new non-protocol marker
pytest.mark.mgmtd,
# pytest.mark.bfdd,
# pytest.mark.isisd,
# pytest.mark.ospfd,
Expand Down
3 changes: 1 addition & 2 deletions tests/topotests/mgmt_config/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@
from lib.common_config import retry, step
from lib.topogen import Topogen, TopoRouter

# pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]
pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@retry(retry_timeout=1, initial_wait=0.1)
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_config/test_regression.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import pytest
from lib.topogen import Topogen

pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_debug_flags/test_debug.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from lib.topogen import Topogen
from munet.watchlog import WatchLog

pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_fe_client/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from lib.topogen import Topogen
from oper import check_kernel_32

pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_oper/test_oper.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
except ImportError:
dd_json_cmp = None

pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_oper/test_querying.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from lib.topogen import Topogen
from oper import check_kernel_32

pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_oper/test_scale.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from lib.topogen import Topogen, TopoRouter
from oper import check_kernel_32

pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_oper/test_simple.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from lib.topogen import Topogen
from oper import check_kernel_32, do_oper_test

pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
3 changes: 1 addition & 2 deletions tests/topotests/mgmt_startup/test_bigconf.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@

CWD = os.path.dirname(os.path.realpath(__file__))

# pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]
pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


track = Timeout(0)
Expand Down
3 changes: 1 addition & 2 deletions tests/topotests/mgmt_startup/test_cfgfile_var.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
from lib.topogen import Topogen, TopoRouter
from util import check_kernel

# pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]
pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
3 changes: 1 addition & 2 deletions tests/topotests/mgmt_startup/test_late_bigconf.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@

CWD = os.path.dirname(os.path.realpath(__file__))

# pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]
pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]

track = Timeout(0)
ROUTE_COUNT = 2500
Expand Down
3 changes: 1 addition & 2 deletions tests/topotests/mgmt_startup/test_late_uniconf.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
from lib.topogen import Topogen
from util import _test_staticd_late_start

# pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]
pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
3 changes: 1 addition & 2 deletions tests/topotests/mgmt_startup/test_latestart.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
from lib.topogen import Topogen, TopoRouter
from util import _test_staticd_late_start

# pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]
pytestmark = [pytest.mark.staticd]
pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]


@pytest.fixture(scope="module")
Expand Down
2 changes: 1 addition & 1 deletion tests/topotests/mgmt_tests/test_yang_mgmt.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
from lib.bgp import verify_bgp_convergence, create_router_bgp, verify_bgp_rib
from lib.topojson import build_config_from_json

pytestmark = [pytest.mark.bgpd, pytest.mark.staticd]
pytestmark = [pytest.mark.bgpd, pytest.mark.staticd, pytest.mark.mgmtd]

# Global variables
ADDR_TYPES = check_address_types()
Expand Down
1 change: 1 addition & 0 deletions tests/topotests/pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ markers =
eigrpd: Tests that run against EIGRPD
isisd: Tests that run against ISISD
ldpd: Tests that run against LDPD
mgmtd: Tests that run against MGMTD
nhrpd: Tests that run against NHRPD
ospf6d: Tests that run against OSPF6D
ospfd: Tests that run against OSPFD
Expand Down
Loading