bgpd: add 'default hostname-capability' #15129
Conversation
The BGP capability option 72 defines the hostname option as per draft-walton-bgp-hostname-capability. It is a draft, and some equipements do not support this option. Add the 'bgp default hostname-capability' command to change the behaviour. Signed-off-by: Philippe Guibert <[email protected]>
| @@ -519,6 +519,7 @@ struct bgp { | |||
| #define BGP_FLAG_LU_IPV6_EXPLICIT_NULL (1ULL << 34) | |||
| #define BGP_FLAG_SOFT_VERSION_CAPABILITY (1ULL << 35) | |||
| #define BGP_FLAG_ENFORCE_FIRST_AS (1ULL << 36) | |||
| #define BGP_FLAG_HOSTNAME_CAPABILITY (1ULL << 36) | |||
| @@ -1896,7 +1896,8 @@ uint16_t bgp_open_capability(struct stream *s, struct peer *peer, | |||
| } | |||
|
|
|||
| /* Hostname capability */ | |||
| if (cmd_hostname_get()) { | |||
| if (CHECK_FLAG(peer->bgp->flags, BGP_FLAG_HOSTNAME_CAPABILITY) && | |||
There was a problem hiding this comment.
this flag should be on by default where are you setting it?
There was a problem hiding this comment.
because in the initial commit, I hesitated to change this behavior.
rationale : draft it not supported everywhere.
consequence if I disable this:
topotests may be complicated, especially with IPv6 setups where the link local nexthop is never tested.
There was a problem hiding this comment.
so I would prefer that this behavior does not get turned off by default. It is used and it is very useful for people who have deployed this. I would consider something like datacenter it is turned on and traditional it is not. Reality is that this needs to be a consensus behavior change from the community. Please plan to bring this up in the next weekly meeting.
There was a problem hiding this comment.
@donaldsharp this is enabled by default.
|
changing to draft. the missing 'neighbor <> capability hostname` command is missing. |
Do you mean to control this per-neighbor? |
|
replaced by #15192 |
The BGP capability option 72 defines the hostname option as per draft-walton-bgp-hostname-capability.
It is a draft, and some equipements do not support this option.
Add the 'bgp default hostname-capability' command to change the behaviour.