Pim vxlan issues #15130
Merged
Pim vxlan issues #15130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing pim vxlan multicast bum handling, setup the register to send up to 10 null registers on immediate startup. If the null register packet gets dropped this delays the formation of the S,G tree from the RP towards the FHR. Signed-off-by: Donald Sharp <[email protected]>
The Join or Prune messages require you to turn on `trace` but this is part of Join/Prune processing of the packet let's use PIM_DEBUG_PIM_J_P instead of TRACE here. Signed-off-by: Donald Sharp <[email protected]>
When turning on debug pim trace, there are lots of messages surrounding the timing of rpf lookup. 99% of the time no-one cares about these anymore. Let's make them not seen unless we turn up debugs Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
pim_vxlan_issues
branch
from
c0020ae to
8e85c8b
Compare
|
LGTM |
ton31337
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One fix to pim vxlan behavior and several debug changes to make debugging easier on the eyes.
The pim vxlan behavior change is to be more persistent about sending the Null Register on startup. Effectively one thing that was noticed during internal testing is that the null register is sometimes not received on the RP. Just sending one at startup time ( when all the other routers/switches are starting up too ) leave you with a situation where the next Null register is 60 seconds out. PIM VXlan wants to build the SPT tree as fast as possible. So let's facilitate this.