lib: mgmtd: convert affinitymap to mgmtd #15153
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
choppsv1
force-pushed
the
chopps/convet-affinity-map
branch
2 times, most recently
from
161c693 to
ed16541
Compare
choppsv1
changed the title
choppsv1
force-pushed
the
chopps/convet-affinity-map
branch
from
ed16541 to
e25b57a
Compare
lib/affinitymap_cli.c
Outdated
| @@ -101,7 +93,7 @@ void cli_show_affinity_map(struct vty *vty, const struct lyd_node *dnode, | |||
| void affinity_map_init(void) | |||
| { | |||
| /* CLI commands. */ | |||
| install_node(&affinitymap_node); | |||
| // install_node(&affinitymap_node); | |||
There was a problem hiding this comment.
Let's remove it completely instead of commenting it out?
| @@ -566,6 +567,9 @@ void mgmt_vty_init(void) | |||
| * backend components that are moved to new MGMTD infra | |||
| * here one by one. | |||
| */ | |||
| affinity_map_init(); | |||
| if_cmd_init(NULL); | |||
There was a problem hiding this comment.
if_cmd_init is already called in mgmt_main.c. Probably makes sense to move it here together with vrf_cmd_init, but we definitely don't want double initialization.
|
PR is failing on the RPM based systems as the |
What should I add it to inside |
choppsv1
force-pushed
the
chopps/convet-affinity-map
branch
2 times, most recently
from
3cebaf6 to
ce364e3
Compare
Signed-off-by: Christian Hopps <[email protected]>
choppsv1
force-pushed
the
chopps/convet-affinity-map
branch
from
ce364e3 to
73f33ad
Compare
The fix was to use the "dist" version of _SOURCES rather than |
There was a problem hiding this comment.
Making this change would mean any new component using affinity-maps would have to be moved to mgmtd infra first (Hope my deduction here was right). Do we really want to put such restrictions?
The new hooks now directly need a dnode as argument. why could we not have retained the old arguments and internally derive it in lib/affinity_map.c before calling the hook. This way the library can be moved to mgmtd without having the clients moved to mgmtd infra too.
This should be discussed in the weekly meeting first. Was this restriction explicitly discussed? I could not attend the weekly for last few weeks. Hence I am not sure.
|
@pushpasis you can keep sending affinity-map commands to non-converted daemons directly, bypassing mgmtd. There's no restriction. This is how VRFs/interfaces work at the moment. |
Even if it doesn't do this, yes We can discuss this in the development meeting but I would be shocked if that's not the answer. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
No description provided.