bgpd: Fix format overflow for graceful-restart debug logs #15210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use enum instead of int, and make the compiler happy when using -format-overflow. Signed-off-by: Donatas Abraitis <[email protected]>
|
@Mergifyio backport stable/9.1 stable/9.0 stable/8.5 |
✅ Backports have been created
|
donaldsharp
reviewed
Jan 24, 2024
| /*This is incremental updates i.e no tear down | ||
| *of the existing session | ||
| *as the peer is already working in the same mode. | ||
| if ((int)new_peer_state == (int)bgp_gr_global_mode) { |
There was a problem hiding this comment.
both are enum_peer_mode right? Why do we need casting to (int)?
There was a problem hiding this comment.
not really, they are different 🤷
This was referenced Jan 24, 2024
ton31337
added a commit
that referenced
this pull request
Jan 25, 2024
bgpd: Fix format overflow for graceful-restart debug logs (backport #15210)
donaldsharp
added a commit
that referenced
this pull request
Jan 25, 2024
bgpd: Fix format overflow for graceful-restart debug logs (backport #15210)
ton31337
added a commit
that referenced
this pull request
Jan 27, 2024
bgpd: Fix format overflow for graceful-restart debug logs (backport #15210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use enum instead of int, and make the compiler happy when using -format-overflow.
Without this patch, it does not compile e.g. on Debian12.