Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile issue fixups #15215

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Compile issue fixups #15215

merged 2 commits into from
Jan 25, 2024

Conversation

donaldsharp
Copy link
Member

a) pceplib was not building for testing unless you have the libcunit1 package installed.
b) bgp_rpki needed to have the correct print formatter.

Just some stuff preventing usage of --enable-werror for builds.

The series of pceplib tests are not being run at the moment
due to them not even building.  Apparently adding the `libcunit1`
debian package is enough to get them to build in our system.
While weird, let's get this building at least for people that
have this and `--enable-werror` turned on.

Signed-off-by: Donald Sharp <[email protected]>
Copy link
Member

@odd22 odd22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ton31337 ton31337 merged commit f31bc32 into FRRouting:master Jan 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants