Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Remove int return for zapi functions #15225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

*: Remove int return for zapi functions #15225

wants to merge 1 commit into from

Conversation

donaldsharp
Copy link
Member

The code never uses the return code for
Zapi functions. Let's remove it.

@ton31337
Copy link
Member

ci:rerun CI failed to trigger github check API or so, it's green, but missed a hook

@donaldsharp
Copy link
Member Author

ci:rerun

@mjstapp
Copy link
Contributor

mjstapp commented Jan 25, 2024

Hmm - but ... I've thought (sometimes) that getting feedback from zapi apis might be one of the ways we'd be able to do a better job of avoiding buffering when sending to zebra. I'd rather leave that possibility open?

@donaldsharp
Copy link
Member Author

This is reception of data from zebra, not sending of data to zebra.

riw777
riw777 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me ... waiting on the conversation around whether we should pull these out to resolve

@donaldsharp donaldsharp force-pushed the return_nothing_for_zapi branch 2 times, most recently from 7ada350 to 61c95eb Compare February 2, 2024 17:17
@donaldsharp donaldsharp force-pushed the return_nothing_for_zapi branch 2 times, most recently from de9f6f1 to 02c1576 Compare February 8, 2024 15:47
@riw777
Copy link
Member

riw777 commented Feb 13, 2024

looks like there are build failures ... :-(

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

@donaldsharp
*: Remove int return for zapi functions
2020be2 
The code never uses the return code for
Zapi functions.  Let's remove it.

Signed-off-by: Donald Sharp <[email protected]>
@donaldsharp donaldsharp force-pushed the return_nothing_for_zapi branch from 02c1576 to 2020be2 Compare October 10, 2024 14:40
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
conflicts master size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donaldsharp @ton31337 @mjstapp @riw777