zebra, build: disable irdp by default #15245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRDP client (rdisc) was deleted from iputils more than 2 years ago. It's time to drop IRDP, but first let's stop building and including it in the packages by default to see if anyone will be complaining. Signed-off-by: Igor Ryzhov <[email protected]>
choppsv1
approved these changes
Jan 28, 2024
| @@ -2334,6 +2334,9 @@ yes) | |||
| no) | |||
| IRDP=false | |||
| ;; | |||
| *) | |||
There was a problem hiding this comment.
What value is this covering for? Would hope that AC_ARG_ENABLE() macro would produce deterministic results (i.e., only yes or no).
There was a problem hiding this comment.
It is neither yes nor no if there's no --enable/disable-irdp argument provided. So it doesn't hit any of the two existing cases. It was ok before, because the default was to enable the feature, but now we have to disable it by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRDP client (rdisc) was deleted from iputils more than 2 years ago. It's time to drop IRDP, but first let's stop building and including it in the packages by default to see if anyone will be complaining.