Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update sysrepo plugin documentation #15249

Closed
wants to merge 1 commit into from
Closed

doc: update sysrepo plugin documentation #15249

wants to merge 1 commit into from

Conversation

adaraiseh
Copy link
Contributor

Added missing modules and tested its functionality

ton31337
ton31337 requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits into a single one.

@adaraiseh adaraiseh marked this pull request as draft January 30, 2024 08:08
@adaraiseh adaraiseh closed this Jan 30, 2024
@github-actions github-actions bot added size/XS and removed size/L labels Jan 30, 2024
@adaraiseh adaraiseh reopened this Jan 30, 2024
@github-actions github-actions bot added size/L and removed size/XS labels Jan 30, 2024
@adaraiseh adaraiseh marked this pull request as ready for review January 30, 2024 08:17
@adaraiseh
Copy link
Contributor Author

@ton31337 the squash is done

@adaraiseh adaraiseh requested a review from ton31337 January 30, 2024 08:19
@adaraiseh adaraiseh closed this Jan 30, 2024
@github-actions github-actions bot added size/XS and removed size/L labels Jan 30, 2024
@adaraiseh adaraiseh reopened this Jan 30, 2024
@github-actions github-actions bot added size/L and removed size/XS labels Jan 30, 2024
@riw777
Copy link
Member

riw777 commented Jan 30, 2024

I think this mostly needs a signed off by line (?) ...

@adaraiseh adaraiseh closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 Awaiting requested review from ton31337

Assignees
No one assigned
Labels
babel bgp bugfix documentation eigrp isis libfrr master mgmt FRR Management Infra nhrp ospf ospfv3 pbr pim rebase PR needs rebase rip ripng sharp size/L tests Topotests, make check, etc vtysh yang zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adaraiseh @riw777 @ton31337