Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: init new bitfield word after realloc #15252

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Jan 29, 2024

Realloc doesn't init - ensure a newly-allocated word is inited.

Realloc doesn't init - ensure a newly-allocated word is inited.

Signed-off-by: Mark Stapp <[email protected]>
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Jan 30, 2024

This seems like a bugfix ... should it be merged during the freeze, or should we wait?

@mjstapp
Copy link
Contributor Author

mjstapp commented Jan 30, 2024

I don't think we're in the freeze yet - we postponed it for a bit?

This seems like a bugfix ... should it be merged during the freeze, or should we wait?

@donaldsharp
Copy link
Member

did you find a bug with this discovery?

@donaldsharp donaldsharp merged commit 71dd971 into FRRouting:master Jan 30, 2024
11 checks passed
@mjstapp mjstapp deleted the fix_bitfield_init branch February 5, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants