lib: Warn operator when fd limit is set too large #15282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unlikely that an operator will ever set a fd limit of over 100k. Let's warn the operator that things are in a bit of a wonky state. Fixes: FRRouting#15280 Signed-off-by: Donald Sharp <[email protected]>
ton31337
approved these changes
Feb 2, 2024
| @@ -543,6 +543,7 @@ static void initializer(void) | |||
| pthread_key_create(&thread_current, NULL); | |||
| } | |||
|
|
|||
| #define STUPIDLY_LARGE_FD_SIZE 100000 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unlikely that an operator will ever set a fd
limit of over 100k. Let's warn the operator that
things are in a bit of a wonky state.
Fixes: #15280