Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: set change errmsg in sysrepo session #15294

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Ali-aqrabawi
Copy link
Contributor

this will enable sysrepo based cli users to know what went wrong when config change fails

an example:

before this change:

pc# conf t
pc(config)# lib-frr-interface 
pc(config-lib-frr-interface)# no interface virbr0
pc(config-lib-frr-interface)# commit
[ERR] User callback failed.
commit_failed: failed to commit changes!
pc(config-lib-frr-interface)#

after this change:

pc(config-lib-frr-interface)# no interface virbr0 
pc(config-lib-frr-interface)# commit 
[ERR] only inactive interfaces can be deleted
[ERR] User callback failed.
commit_failed: failed to commit changes!
pc(config-lib-frr-interface)#

this will enable sysrepo based cli users to know what went wrong
when config change fails

Signed-off-by: ali-aqrabawi <[email protected]>
@frrbot frrbot bot added the libfrr label Feb 3, 2024
@ton31337 ton31337 added this to the 10.0 milestone Feb 4, 2024
@donaldsharp donaldsharp merged commit 87b69cd into FRRouting:master Feb 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants