Rcu bites the bitey thing #15298
Merged
Rcu bites the bitey thing #15298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a non-controlled startup, the rcu data structures were not being created until after logging could happen. This is bad. Move it so that the rcu data structures are created first, before logging( HA! ) can happen. Signed-off-by: Donald Sharp <[email protected]>
As far as I can tell, the rpki code creates a pthread that is used to handle the i/o associated with talking to the remote rpki server. The problem that we are having is that the rpki code in FRR wants to behave like FRR code and use the zlog_XXX functions. These functions all depend on the RCU code. Which is a bit picky( and rightly so!!! ) about being started up properly and shut down properly. This commit is fixing the problem of shutdown. From playing with the rpki code, I was able to experimentally determine that the rpki_create_socket callback function can be called multiple times per pthread. Additionally I was able to clearly see multiple *different* pthreads actually be created. This leaves the possiblity that each time it is called it might be hooking into the RCU code. Which makes the rcu code unhappy on shutdown. Let's address the issue by checking to see if this pthread has already hooked into the RCU code or not. If so then don't do this again. Signed-off-by: Donald Sharp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.