bgpd: Send FQDN capability via dynamic capability if enabled #15301
Conversation
Since we have a knob to disable sending FQDN capability, it MUST be checked before sending it using dynamic capabilities. Signed-off-by: Donatas Abraitis <[email protected]>
Allow BGP dynamic capabilities handle this gracefully. Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/fqdn_capability_dynamic
branch
from
b94ddf1 to
c8acc67
Compare
| @@ -4574,7 +4574,7 @@ static const struct peer_flag_action peer_flag_action_list[] = { | |||
| {PEER_FLAG_AIGP, 0, peer_change_none}, | |||
| {PEER_FLAG_GRACEFUL_SHUTDOWN, 0, peer_change_none}, | |||
| {PEER_FLAG_CAPABILITY_SOFT_VERSION, 0, peer_change_none}, | |||
| {PEER_FLAG_CAPABILITY_FQDN, 0, peer_change_reset}, | |||
| {PEER_FLAG_CAPABILITY_FQDN, 0, peer_change_none}, | |||
| {0, 0, 0}}; | |||
There was a problem hiding this comment.
are you sure ? cisco does resets upon config ?
There was a problem hiding this comment.
why are you changing the behaviour ?
I think an other product vendor like cisco does perform a reset when the fqdn param is modified.
so we want to keep this behaviour identical.
what is the reason why you set it to none?
There was a problem hiding this comment.
Because dynamic capabilities logic makes no sense then. If you have dynamic capabilities, the reset is not necessary.
|
@ton31337 is this a bug fix or a feature? This feels more like a feature than a bug fix, yet you've marked it for 10.0 |
|
it's not a feature, it's a broken implementation that was just recently added for fqdn capability "disable mode". If we have dynamic capabilities enabled, then without this fix, fqdn capability will be send despite it's disabled. |
No description provided.