Nhg stuffs #15332
Merged
Nhg stuffs #15332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing a NHG via dplane_nexthop_add, it can only return REQUEST_QUEUED or REQUEST_FAILURE. There is no way SUCCESS can be returned with the way the dplane works at this point in time. Remove the code that attempts to set the NHE state appropriately as it is impossible. Signed-off-by: Donald Sharp <[email protected]>
The documentation was wrong. Let's adjust it. Signed-off-by: Donald Sharp <[email protected]>
Basically the same function two times. Let's consolidate. Signed-off-by: Donald Sharp <[email protected]>
Convert the dplane results function for nhg's over to using a switch for the result enum. Let's specifically call out the unexpected state and also set the nexthop group as not installed when installation fails. Signed-off-by: Donald Sharp <[email protected]>
The nexthop group is marked as valid/invalid and then installed. Not installed and then marked valid. This is just a bit of code removed that might be covering up other problems that need to be sorted. Signed-off-by: Donald Sharp <[email protected]>
Let's just let the function figure this out. Signed-off-by: Donald Sharp <[email protected]>
These functions provided a level of abstraction that forced us to call multiple functions when a simple data structure change was all that is needed. Let's consolidate down and make things a bit simpler. Signed-off-by: Donald Sharp <[email protected]>
zebra_if_nhg_dependents_XXX were just simple wrapper functions that inited/deleted data structures. These were already function calls themselves. Let's remove the abstraction and make the code simpler. Signed-off-by: Donald Sharp <[email protected]>
The function call in to zebra_interface_nhg_reinstall is an action that takes place on interface up events *not* when the connected addresses are added to a system. this will prevent this function being called when new connected interfaces come alive that is an independent operation of the interface coming up. Signed-off-by: Donald Sharp <[email protected]>
The current code is unsetting the fact that the NHG is installed. It is installed but we are reinstalling it. Let's note this in the code appropriately as REINSTALL and not remove the INSTALLED FLAG. Signed-off-by: Donald Sharp <[email protected]>
ton31337
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits but this is a bunch of code cleanup.