Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmtd: remove unused commit phase SEND_CFG #15359

Merged
merged 1 commit into from
Feb 14, 2024
Merged

mgmtd: remove unused commit phase SEND_CFG #15359

merged 1 commit into from
Feb 14, 2024

Conversation

choppsv1
Copy link
Contributor

No description provided.

@frrbot frrbot bot added the mgmt FRR Management Infra label Feb 12, 2024
@choppsv1 choppsv1 force-pushed the chopps/reap-unused-phase branch from b94a89d to 40e51d2 Compare February 12, 2024 12:57
@idryzhov
Copy link
Contributor

I'm not sure about this. This phase is not processed in mgmt_txn_process_commit_cfg, but it's still a separate phase, at least for the backend daemons. We are creating a transaction first, and if it fails then we don't send the config. If we want to actually remove it, then we should combine txn creation and config sending into a single message?

idryzhov
idryzhov approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@idryzhov idryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack, the process may be simplified even more, and this is the first step.

@idryzhov idryzhov merged commit cccfedb into FRRouting:master Feb 14, 2024
9 checks passed
@choppsv1 choppsv1 deleted the chopps/reap-unused-phase branch February 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idryzhov idryzhov idryzhov approved these changes

Assignees
No one assigned
Labels
master mgmt FRR Management Infra size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@choppsv1 @idryzhov