Add ability to test dplane_fpm_nl.c file #15369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
force-pushed
the
fpm_stub_addition
branch
2 times, most recently
from
9ff4f83 to
a9b0c01
Compare
donaldsharp
force-pushed
the
fpm_stub_addition
branch
4 times, most recently
from
7859716 to
8c7b126
Compare
donaldsharp
force-pushed
the
fpm_stub_addition
branch
2 times, most recently
from
12f4e88 to
51e8805
Compare
|
FRRbot's failure is because black and checkpatch disagree with each other. Frankly I prefer blacks output so I'm leaving it alone. |
donaldsharp
force-pushed
the
fpm_stub_addition
branch
5 times, most recently
from
6ee3d1d to
eab21bd
Compare
ton31337
reviewed
Feb 16, 2024
| from lib.topolog import logger | ||
|
|
||
|
|
||
| pytestmark = [pytest.mark.sharpd] |
There was a problem hiding this comment.
Shouldn't we add another mark for FPM? tests/topotests/pytest.ini
donaldsharp
force-pushed
the
fpm_stub_addition
branch
2 times, most recently
from
1990ec1 to
bc85aaa
Compare
ton31337
reviewed
Feb 23, 2024
| @@ -102,6 +102,14 @@ Description: FRRouting suite - BGP RPKI support (rtrlib) | |||
| number. | |||
| Build-Profiles: <!pkg.frr.nortrlib> | |||
|
|
|||
| Package: frr-test-tools | |||
There was a problem hiding this comment.
I spent 2 seconds looking at it and decided I have no idea how to do this in rpm land. If someone needs this as part of the rpm stuff, then they can add it. I feel it is ok for this approach because of the low usage of rpms
donaldsharp
force-pushed
the
fpm_stub_addition
branch
2 times, most recently
from
3dfd7e8 to
f5208d7
Compare
donaldsharp
force-pushed
the
fpm_stub_addition
branch
from
f5208d7 to
8589f16
Compare
checkpatch.pl wants you to use ARRAY_SIZE in a kernel header file. We don't have access to this kernel header file for normal compilation. I'm just going to remove it. Signed-off-by: Donald Sharp <[email protected]>
Add a tiny fpm_listener program to allow FRR to test the fpm. Signed-off-by: Donald Sharp <[email protected]>
Add a command to get the status of the dplane_fpm_nl module. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Add the ability to run a fpm listener to the testing system. This is nothing more just allowing the test system to bring it up. Signed-off-by: Donald Sharp <[email protected]>
Ensure that the fpm module connects to the specified listener and then ensure that 10k routes from sharpd are installed into the system and then are removed. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
This package will hold test tools that are built and useful for developers of FRR but not useful for everyday usage of FRR. This is separted out because these are useful enough to have in their own package. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
fpm_stub_addition
branch
from
8589f16 to
0beabd7
Compare
mwinter-osr
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to test the fpm module dplane_fpm_nl.c.
This includes a new daemon that needs to be added to the system from:
[email protected]:donaldsharp/fpm-stub.git