debian: Ensure we properly depend on the right version of libyang2 #15373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jafaral
reviewed
Feb 15, 2024
idryzhov
requested changes
Feb 15, 2024
Fixes: FRRouting#15372 Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
fix_libyang_depends
branch
from
ee50dd4 to
ee4d02a
Compare
Signed-off-by: Donald Sharp <[email protected]>
ton31337
approved these changes
Feb 16, 2024
|
@idryzhov is this fine now? |
|
The change adds the libyang version to FRR package dependencies, but it doesn't really fix the root of the problem. Something is wrong with libyang packages provided from FRR deb repo as I explained in #15372 (comment). The change also makes it necessary to update the version in two places instead of one, when libyang dependency is updated. I think it's better to fix the actual problem instead of merging this. |
|
@Jafaral do you know how to fix this properly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15372