Ttable vty finish #15386
Open
Ttable vty finish #15386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent pattern was this: out = ttable_dump(tt, "\n"); vty_out(vty, "%s", out); XFREE(MTYPE_TMP, out); ttable_del(tt); Let's just consolidate this pattern into ttable_vty_finish. Since no-one ever used it any other way. Signed-off-by: Donald Sharp <[email protected]>
There is another common pattern in the usage of ttable_vty_finish
that is this:
if (tt->nrows > 1) {
ttable_vty_finish(vty, &tt, "\n");
} else {
vty_out(vty, "No configuration transactions to display.\n\n");
ttable_del(tt);
}
Let's move this into the ttable_vty_finish function and let
callers specify the string to use when the table is empty.
Signed-off-by: Donald Sharp <[email protected]>
|
Valid failures though. |
choppsv1
reviewed
Feb 19, 2024
| void ttable_vty_finish(struct vty *vty, struct ttable **tt, const char *newline, | ||
| const char *display_if_no_rows) | ||
| { | ||
| if ((*tt)->nrows > 1) { |
There was a problem hiding this comment.
I didn't dig too deeply but should this really be > 1 rather than > 0?
| * @param tt - double pointer to the table to dump, this pointer | ||
| * is freed. | ||
| * @param newline the desired newline sequence to use, null terminated. | ||
| * @param display_if_no_rows The string to display if nrows is 0 |
There was a problem hiding this comment.
This description is incorrect as it will currently (perhaps erroneously) display the string if nrows is 0 or 1.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a ttable_vty_finish function that encapsulates common coding patterns. See the individual commits for details.