Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix access/prefix-list entry update #15427

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

idryzhov
Copy link
Contributor

@idryzhov idryzhov commented Feb 25, 2024

lib: fix access-list entry update

When an access-list entry is updated, current NB code calls notification
hooks for each updated field. It means that when multiple fields of an
entry are changed in a single commit, the hooks are run with an interim
state of an access-list instead of a final one. To fix the issue, we
should call the hooks once, after all fields of an entry are updated.
lib: fix prefix-list entry update

When a prefix-list entry is updated, current NB code calls the
replacement code multiple times, once per each updated field. It means
that when multiple fields of an entry are changed in a single commit,
the replacement is done with an interim state of a prefix-list instead
of a final one. To fix the issue, we should call the replacement code
once, after all fields of an entry are updated.

When an access-list entry is updated, current NB code calls notification
hooks for each updated field. It means that when multiple fields of an
entry are changed in a single commit, the hooks are run with an interim
state of an access-list instead of a final one. To fix the issue, we
should call the hooks once, after all fields of an entry are updated.

Signed-off-by: Igor Ryzhov <[email protected]>
When a prefix-list entry is updated, current NB code calls the
replacement code multiple times, once per each updated field. It means
that when multiple fields of an entry are changed in a single commit,
the replacement is done with an interim state of a prefix-list instead
of a final one. To fix the issue, we should call the replacement code
once, after all fields of an entry are updated.

Signed-off-by: Igor Ryzhov <[email protected]>
@idryzhov
Copy link
Contributor Author

@Mergifyio backport dev/10.0

Copy link

mergify bot commented Feb 25, 2024

backport dev/10.0

✅ Backports have been created

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ton31337 ton31337 added this to the 10.0 milestone Feb 26, 2024
@ton31337 ton31337 merged commit 7ad689b into FRRouting:master Feb 27, 2024
13 checks passed
riw777 added a commit that referenced this pull request Feb 27, 2024
lib: fix access/prefix-list entry update (backport #15427)
@birdofprey
Copy link

frr实现一个M-LAG或者Vpc的具体实现对于Linux第一条和VRRP协议都是里程碑和划时代的创举!!!frr加油!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants