Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: fix crash when macvlan link-interface is in another netns (backport #15399) #15444

Merged
merged 1 commit into from
Feb 27, 2024

zebra: fix crash if macvlan link in another netns

669388b
Select commit
Loading
Failed to load commit list.
Merged

zebra: fix crash when macvlan link-interface is in another netns (backport #15399) #15444

zebra: fix crash if macvlan link in another netns
669388b
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / [CI] Basic Tests failed Feb 27, 2024 in 1s

Basic Tests summary

➡️ Jobs in progress: 0/59

✖️ Jobs Failure: 5/59

E   AssertionError: "rt2" didn't receive a Grace-LSA from "1.1.1.1"
   assert Generated JSON diff error report:
     
     > $->linkLocalOpaqueLsa->areas->0.0.0.1: d1 has Array of length 0 but in d2 it is of length 1
E   AssertionError: Testcase test_ospfv3_tc4_mtu_ignore_p0 : Failed 
      Error: [DUT: r1] missing OSPF neighbor r0 with router-id 100.1.1.0
   assert '[DUT: r1] missing OSPF neighbor r0 with router-id 100.1.1.0' is True
E   KeyError: 'installed'
E   AssertionError: "rt1" JSON output mismatches the expected result
   assert Generated JSON diff error report:
     
     > $->2001:db8:1000::2/128: d2 has the following element at index 0 which is not present in d1: 
     
     	{
     	    "prefix": "2001:db8:1000::2/128",
     	    "protocol": "isis",
     	    "selected": true,
     	    "destSelected": true,
     	    "distance": 115,
     	    "metric": 25,
     	    "installed": true,
     	    "nexthops": [
     	        {
     	            "fib": true,
     	            "afi": "ipv6",
     	            "interfaceName": "eth-rt3",
     	            "active": true
     	        }
     	    ]
     	}
     
     	Closest match in d1 is at index 0 with the following errors: 
     
     	> $->2001:db8:1000::2/128[0]: d2 has key 'installed' which is not present in d1
     
     > $->2001:db8:1000::7/128: d2 has the following element at index 0 which is not present in d1: 
     
     	{
     	    "prefix": "2001:db8:1000::7/128",
     	    "protocol": "isis",
     	    "selected": true,
     	    "destSelected": true,
     	    "distance": 115,
     	    "metric": 30,
     	    "installed": true,
     	    "nexthops": [
     	        {
     	            "fib": true,
     	            "afi": "ipv6",
     	            "interfaceName": "eth-rt6",
     	            "active": true
     	        }
     	    ]
     	}
     
     	Closest match in d1 is at index 0 with the following errors: 
     
     	> $->2001:db8:1000::7/128[0]: d2 has key 'installed' which is not present in d1
E   AssertionError: "r1" TED JSON output mismatches the expected result
   assert Generated JSON diff error report:
     
     > $->ted->edges: d2 has the following element at index 4 which is not present in d1: 
     
     	{
     	    "edge-id": "2001:db8:5::3:4",
     	    "status": "Sync",
     	    "origin": "ISIS_L2",
     	    "advertised-router": "0000.0000.0004",
     	    "local-vertex-id": 4,
     	    "remote-vertex-id": 3,
     	    "metric": 10,
     	    "edge-attributes": {
     	        "local-address-v6": "2001:db8:5::3:4",
     	        "remote-address-v6": "2001:db8:5::4:3",
     	        "max-link-bandwidth": 1250000,
     	        "max-resv-link-bandwidth": 1250000,
     	        "unreserved-bandwidth": [
     	            {
     	                "class-type-0": 1250000
     	            },
     	            {
     	                "class-type-1": 1250000
     	            },
     	            {
     	                "class-type-2": 1250000
     	            },
     	            {
     	                "class-type-3": 1250000
     	            },
     	            {
     	                "class-type-4": 1250000
     	            },
     	            {
     	                "class-type-5": 1250000
     	            },
     	            {
     	                "class-type-6": 1250000
     	            },
     	            {
     	                "class-type-7": 1250000
     	            }
     	        ]
     	    },
     	    "segment-routing": [
     	        {
     	            "adj-sid": 5001,
     	            "flags": "0xb0",
     	            "weight": 0
     	        }
     	    ]
     	}
     
     	Closest match in d1 is at index 8 with the following errors: 
     
     	> $->ted->edges[8]->segment-routing: d2 has the following element at index 0 which is not present in d1: 
     	
     		{
     		    "adj-sid": 5001,
     		    "flags": "0xb0",
     		    "weight": 0
     		}
     	
     		Closest match in d1 is at index 0 with the following errors: 
     	
     		> $->ted->edges[8]->segment-routing[0]->adj-sid: d1 has element with value '5000' but in d2 it has value '5001'
     	
     
     > $->ted->edges: d2 has the following element at index 13 which is not present in d1: 
     
     	{
     	    "edge-id": "10.0.4.4",
     	    "status": "Sync",
     	    "origin": "ISIS_L2",
     	    "advertised-router": "0000.0000.0004",
     	    "local-vertex-id": 4,
     	    "remote-vertex-id": 2,
     	    "metric": 10,
     	    "edge-attributes": {
     	        "local-address": "10.0.4.4",
     	        "remote-address": "10.0.4.2",
     	        "max-link-bandwidth": 1250000,
     	        "max-resv-link-bandwidth": 1250000,
     	        "unreserved-bandwidth": [
     	            {
     	                "class-type-0": 1250000
     	            },
     	            {
     	                "class-type-1": 1250000
     	            },
     	            {
     	                "class-type-2": 1250000
     	            },
     	            {
     	                "class-type-3": 1250000
     	            },
     	            {
     	                "class-type-4": 1250000
     	            },
     	            {
     	                "class-type-5": 1250000
     	            },
     	            {
     	                "class-type-6": 1250000
     	            },
     	            {
     	                "class-type-7": 1250000
     	            }
     	        ]
     	    },
     	    "segment-routing": [
     	        {
     	            "adj-sid": 5000,
     	            "flags": "0x30",
     	            "weight": 0
     	        }
     	    ]
     	}
     
     	Closest match in d1 is at index 0 with the following errors: 
     
     	> $->ted->edges[0]->segment-routing: d2 has the following element at index 0 which is not present in d1: 
     	
     		{
     		    "adj-sid": 5000,
     		    "flags": "0x30",
     		    "weight": 0
     		}
     	
     		Closest match in d1 is at index 0 with the following errors: 
     	
     		> $->ted->edges[0]->segment-routing[0]->adj-sid: d1 has element with value '5001' but in d2 it has value '5000'

✔️ Jobs Success: 54/59

Details at https://ci1.netdef.org/browse/FRR-PULLREQ3-2039.