docker: Fix build for Alpine Linux after the recent changes since 9.1 #15457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport dev/10.0 |
🟠 Waiting for conditions to match
|
ton31337
force-pushed
the
fix/docker_builds_for_10.0
branch
from
16d24c7 to
f71668c
Compare
✅ Backports have been created
|
|
I think this is still work in progress (?) ... |
|
Nope, it's ready to be merged. |
donaldsharp
reviewed
Mar 8, 2024
donaldsharp
reviewed
Mar 8, 2024
Signed-off-by: Donatas Abraitis <[email protected]>
This is happening for Alpine Linux. ``` 26 64.59 ./lib/sigevent.h:23:18: error: unknown type name 'sig_atomic_t' 26 64.59 23 | volatile sig_atomic_t caught; /* private member */ 26 64.59 | ^~~~~~~~~~~~ 26 64.60 In file included from ./lib/libfrr.h:12, 26 64.60 from ./lib/vty.h:28, 26 64.60 from ./lib/command.h:11, 26 64.60 from ./lib/debug.h:11, 26 64.60 from ./mgmtd/mgmt.h:12, 26 64.60 from mgmtd/mgmt_history.c:14: 26 64.60 ./lib/sigevent.h:23:18: error: unknown type name 'sig_atomic_t' 26 64.60 23 | volatile sig_atomic_t caught; /* private member */ 26 64.60 | ^~~~~~~~~~~~ ``` Signed-off-by: Donatas Abraitis <[email protected]>
Fixing compilation for Alpine Linux: ``` 25 91.59 vtysh/vtysh_main.c: In function 'vtysh_flock_config': 25 91.59 vtysh/vtysh_main.c:276:20: warning: implicit declaration of function 'open'; did you mean 'popen'? [-Wimplicit-function-declaration] 25 91.59 276 | flock_fd = open(flock_file, O_RDONLY, 0644); 25 91.59 | ^~~~ 25 91.59 | popen 25 91.60 vtysh/vtysh_main.c:276:37: error: 'O_RDONLY' undeclared (first use in this function) 25 91.60 276 | flock_fd = open(flock_file, O_RDONLY, 0644); 25 91.60 | ^~~~~~~~ 25 91.60 vtysh/vtysh_main.c:276:37: note: each undeclared identifier is reported only once for each function it appears in 25 91.60 CC zebra/if_netlink.o 25 91.61 vtysh/vtysh_main.c: In function 'main': 25 91.61 vtysh/vtysh_main.c:637:49: error: 'O_CREAT' undeclared (first use in this function) 25 91.61 637 | fp = open(history_file, O_CREAT | O_EXCL, 25 91.61 | ^~~~~~~ 25 91.62 vtysh/vtysh_main.c:637:59: error: 'O_EXCL' undeclared (first use in this function) 25 91.62 637 | fp = open(history_file, O_CREAT | O_EXCL, 25 91.62 | ^~~~~~ ``` Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
Alpine Linux gets this with 3.19: This is already installed with `pytest` via apk package manager. ``` 15 78.20 error: externally-managed-environment 15 78.20 15 78.20 × This environment is externally managed 15 78.20 ╰─> 15 78.20 The system-wide python installation should be maintained using the system 15 78.20 package manager (apk) only. 15 78.20 15 78.20 If the package in question is not packaged already (and hence installable via 15 78.20 "apk add py3-somepackage"), please consider installing it inside a virtual 15 78.20 environment, e.g.: 15 78.20 15 78.20 python3 -m venv /path/to/venv 15 78.20 . /path/to/venv/bin/activate 15 78.20 pip install mypackage 15 78.20 15 78.20 To exit the virtual environment, run: 15 78.20 15 78.20 deactivate 15 78.20 15 78.20 The virtual environment is not deleted, and can be re-entered by re-sourcing 15 78.20 the activate file. 15 78.20 15 78.20 To automatically manage virtual environments, consider using pipx (from the 15 78.20 pipx package). 15 78.20 15 78.20 note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages. ``` Signed-off-by: Donatas Abraitis <[email protected]>
It was using a wrong sysdir. ``` -------------------- 72 | # Own the config / PID files 73 | RUN mkdir -p /var/run/frr 74 | >>> RUN chown -R frr:frr /etc/frr /var/run/frr 75 | 76 | # Simple init manager for reaping processes and forwarding signals -------------------- ``` Signed-off-by: Donatas Abraitis <[email protected]>
Not needed anymore since FRRouting@a538915. Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/docker_builds_for_10.0
branch
from
f71668c to
a201559
Compare
ton31337
added a commit
that referenced
this pull request
Mar 13, 2024
docker: Fix build for Alpine Linux after the recent changes since 9.1 (backport #15457)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.