mgmtd: add support for native 'edit' operation #15468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryzhov
force-pushed
the
mgmt-native-edit
branch
2 times, most recently
from
fc45f09 to
5ce038c
Compare
idryzhov
force-pushed
the
mgmt-native-edit
branch
from
5ce038c to
fb36e75
Compare
idryzhov
force-pushed
the
mgmt-native-edit
branch
2 times, most recently
from
387d0d0 to
9048226
Compare
This operation basically implements support for RESTCONF operations. It receives an xpath and a data tree in JSON/XML format, instead of a list of (xpath, value) tuples as required by the current protobuf interface. Signed-off-by: Igor Ryzhov <[email protected]>
Signed-off-by: Igor Ryzhov <[email protected]>
idryzhov
force-pushed
the
mgmt-native-edit
branch
from
9048226 to
1046bef
Compare
choppsv1
reviewed
Apr 22, 2024
| lyd_insert_sibling(candidate->dnode, | ||
| existing, | ||
| &candidate->dnode); | ||
| } |
There was a problem hiding this comment.
This code is somewhat tricky to understand at first; maybe adding a comment will improve the clarity? Also a small format change...
if (root)
candidate->dnode = existing;
else if (ex_parent)
lyd_insert_child(ex_parent, existing);
else
/*
* replaced a root level node, this makes sure
* candidate->dnode linkage is updated
*/
lyd_insert_sibling(candidate->dnode, existing,
&candidate->dnode);
There was a problem hiding this comment.
Please consider making this change after rebasing #15594
choppsv1
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operation basically implements support for RESTCONF operations. It receives an xpath and a data tree in JSON/XML format, instead of a list of (xpath, value) tuples as required by the current protobuf interface.