lib: fix __darr_in_vsprintf #15470
Merged
lib: fix __darr_in_vsprintf #15470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the initial darr capacity is not enough for the output, the `ap` is reused multiple times, which is wrong, because it may be altered by `vsnprintf`. Make a copy of `ap` each time instead of reusing. Signed-off-by: Igor Ryzhov <[email protected]>
|
@Mergifyio backport dev/10.0 |
✅ Backports have been created
|
choppsv1
approved these changes
Mar 4, 2024
`darr_avail` returns the available capacity excluding the already existing terminating NULL byte. Take this into account when using `darr_avail`. Otherwise, if the error length is a power of 2, the capacity is never enough and the function stucks in an infinite loop. Signed-off-by: Igor Ryzhov <[email protected]>
idryzhov
force-pushed
the
fix-darr-vsprintf
branch
from
65567b5 to
cb6032d
Compare
choppsv1
approved these changes
Mar 5, 2024
idryzhov
added a commit
that referenced
this pull request
Mar 5, 2024
lib: fix __darr_in_vsprintf (backport #15470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initial darr capacity is not enough for the output, the
apis reused multiple times, which is wrong, because it may be altered byvsnprintf. Make a copy ofapeach time instead of reusing.