tools: Add option to frr-reload to specify alternate logfile #15471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwinter-osr
force-pushed
the
frrreload_logfile
branch
from
ec6d877 to
3753bbe
Compare
choppsv1
requested changes
Mar 6, 2024
| @@ -1921,11 +1927,11 @@ def compare_context_objects(newconf, running): | |||
| ) | |||
|
|
|||
| elif args.reload: | |||
| if not os.path.isdir("/var/log/frr/"): | |||
| os.makedirs("/var/log/frr/", mode=0o0755) | |||
| if not os.path.isdir(os.path.dirname(args.logfile)): | |||
There was a problem hiding this comment.
Please update the comment at the top of the block to read
# For --reload log to --logfile (default: "/var/log/frr/frr-reload.log")
Adding option --logfile to specify a different logfile instead of the default /var/log/frr/frr-reload.log Signed-off-by: Martin Winter <[email protected]>
Signed-off-by: Martin Winter <[email protected]>
mwinter-osr
force-pushed
the
frrreload_logfile
branch
from
3753bbe to
81719d8
Compare
|
ci:retry |
|
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
|
@mwinter-osr Did we still want to get this in? Also as a further improvement should the path for the default log file use some value from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option --logfile to specify a different logfile instead of the default /var/log/frr/frr-reload.log
This solves the issue with multiple FRR instances running in different network namespaces to use different
logfiles
Signed-off-by: Martin Winter [email protected]