ospf6d: add localIfaceAdress field #15474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add localIfaceAdress field in show ipv6 ospf6 neighbor detail json command. Signed-off-by: Francois Dumontet <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>
ton31337
reviewed
Mar 4, 2024
| @@ -1004,6 +1004,8 @@ static void ospf6_neighbor_show_detail(struct vty *vty, | |||
| on->ospf6_if->interface->ifindex); | |||
| json_object_int_add(json_neighbor, "neighborInterfaceIndex", | |||
| on->ifindex); | |||
| json_object_string_addf(json_neighbor, "localIfaceAddress", | |||
There was a problem hiding this comment.
Wouldn't be better to name it linkLocalAddress?
There was a problem hiding this comment.
Well it does beg the question, what the next json_object_string_add below is and how it is different than the addition of this particular field.
There was a problem hiding this comment.
ah the linklocal_addr as set on 988 is the neighbors LL address. Louis is attempting to show this router's interface LL address.
|
The idea was to have the same name in show IPv6 and IPv4 ospf* neighbor detail json command |
The only difference is that it is link-local, while IPv4 - not? |
|
PR to be closed due to Louis's absence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add localIfaceAdress field in show ipv6 ospf6 neighbor detail json command.