zebra: changes for code maintainability #15480
Conversation
sri-mohan1
changed the title
these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <[email protected]>
sri-mohan1
force-pushed
the
srib-24-zebra
branch
from
205b4aa to
c7b4069
Compare
| @@ -175,8 +175,7 @@ void zebra_evpn_install_neigh_hash(struct hash_bucket *bucket, void *ctxt) | |||
| n = (struct zebra_neigh *)bucket->data; | |||
|
|
|||
| if (CHECK_FLAG(n->flags, ZEBRA_NEIGH_REMOTE)) | |||
| zebra_evpn_rem_neigh_install(wctx->zevpn, n, | |||
| false /*was_static*/); | |||
| zebra_evpn_rem_neigh_install(wctx->zevpn, n, false /*was_static*/); | |||
There was a problem hiding this comment.
Hi @mjstapp , Thanks for your time in reviewing the changes.
In many places the clang-format is not proper, for example in the above code snippet the params can be includuded in the same line but it got devided and giving in multiple lines. Am just trying to correct this only on the places where can be corrected, remaining all other places am keeping as it is. thanks
There was a problem hiding this comment.
I think the issue will be that we're using clang-format and our config file for it as a reference for now. Diverging from it, other than for a couple of well-known patterns such as cli definition blocks, is going to be confusing.
| old_static = zebra_evpn_mac_is_static(mac); | ||
| ++mac->sync_neigh_cnt; | ||
| new_static = zebra_evpn_mac_is_static(mac); | ||
| if (IS_ZEBRA_DEBUG_EVPN_MH_NEIGH) | ||
| zlog_debug( | ||
| "sync-neigh ref mac vni %u ip %pIA mac %pEA ref %d", | ||
| n->zevpn->vni, &n->ip, &n->emac, | ||
| mac->sync_neigh_cnt); | ||
| n->zevpn->vni, &n->ip, &n->emac, mac->sync_neigh_cnt); |
sri-mohan1
changed the title
|
ci:rerun |
|
ci:rerun |
|
Please stop re-running CI on these changes - we can't merge these changes until clang-format is clean (in general) |
|
Changes may not be useful. |
these changes are for improving the code maintainability and readability