Code

Bgp nexthop group optimisations#15488

Code

Draft

pguibert6WIND wants to merge 69 commits intoFRRouting:masterFRRouting/frr:masterfrom pguibert6WIND:bgp_nhg_optimisationspguibert6WIND/frr:bgp_nhg_optimisationsCopy head branch name to clipboard

+12,449-658

Commits

Commits on Oct 21, 2024

• Revert "zebra: Attempt to reuse NHG after interface up and route reinstall"

  Show description for 79a37d0
  pguibert6WIND

  committed
  79a37d0

  Copy full SHA for 79a37d0

• Revert "zebra: Reinstall nexthop when interface comes back up"

  Show description for 34b7b5d
  pguibert6WIND

  committed
  34b7b5d

  Copy full SHA for 34b7b5d

• Revert "zebra: Properly note that a nhg's nexthop has gone down"

  Show description for 482815e
  pguibert6WIND

  committed
  482815e

  Copy full SHA for 482815e

• Revert "zebra: Pass in ZEBRA_ROUTE_MAX instead of true"

  Show description for 5875425
  pguibert6WIND

  committed
  5875425

  Copy full SHA for 5875425

• zebra: rework zebra_nhg_proto_add() parameters

  Show description for 3610f69
  pguibert6WIND

  committed
  3610f69

  Copy full SHA for 3610f69

• zebra, lib: add allow-recursion flag to nexthop-group

  Show description for 7ad9ee1
  pguibert6WIND

  committed
  7ad9ee1

  Copy full SHA for 7ad9ee1

• zebra: fix submit protocol NHG add/update to nexthop_active() function

  Show description for 11bbd74
  pguibert6WIND

  committed
  11bbd74

  Copy full SHA for 11bbd74

• sharpd: unlock to create unresolved NHGs

  Show description for e286c4b
  pguibert6WIND

  committed
  e286c4b

  Copy full SHA for e286c4b

• lib, doc: add recursive support configuration for nexthop-group

  Show description for 2f25645
  pguibert6WIND

  committed
  2f25645

  Copy full SHA for 2f25645

• sharpd: add 'use-protocol-nexthop-group' keyword for route install

  Show description for eca92b2
  pguibert6WIND

  committed
  eca92b2

  Copy full SHA for eca92b2

• zebra: extract nhe copy from nexthop_active_update()

  Show description for b9707c4
  pguibert6WIND

  committed
  b9707c4

  Copy full SHA for b9707c4

• topotests: add nexthop-group allow-recursion test

  Show description for 12fbdeb
  pguibert6WIND

  committed
  12fbdeb

  Copy full SHA for 12fbdeb

• lib, zebra, doc: extend ibgp support to nhg in zebra

  Show description for 304274e
  pguibert6WIND

  committed
  304274e

  Copy full SHA for 304274e

• zebra, lib: add message flags to nhg_add zapi

  Show description for dac471f
  pguibert6WIND

  committed
  dac471f

  Copy full SHA for dac471f

• lib, doc, sharp, zebra: add color support configuration for nexthops of nexthop-groups

  Show description for e3cdb45
  pguibert6WIND

  committed
  e3cdb45

  Copy full SHA for e3cdb45

• sharpd: add a color option to watch colored nexthop changes

  Show description for e252ada
  pguibert6WIND

  committed
  e252ada

  Copy full SHA for e252ada

• topotests: all_protocol_startup, add color test

  Show description for ff23eef
  pguibert6WIND

  committed
  ff23eef

  Copy full SHA for ff23eef

• lib: rename nexthop_group hook framework function calls

  Show description for 8a648c0
  pguibert6WIND

  committed
  8a648c0

  Copy full SHA for 8a648c0

• lib, doc: add group command under nexthop-group sub node

  Show description for 33f4f32
  pguibert6WIND

  committed
  33f4f32

  Copy full SHA for 33f4f32

• lib, zebra: add NHG_CHILD_ADD message support

  Show description for 6544e4e
  pguibert6WIND

  committed
  6544e4e

  Copy full SHA for 6544e4e

• sharpd, lib: add nexthop-group child group support

  Show description for 1f37e0b
  pguibert6WIND

  committed
  1f37e0b

  Copy full SHA for 1f37e0b

• topotests: all_protocol_startup, add nexthop-group test for child groups

  Show description for 8584256
  pguibert6WIND

  committed
  8584256

  Copy full SHA for 8584256

• zebra: fix update protocol nexthop-group fib flag value

  Show description for 9229863
  pguibert6WIND

  committed
  9229863

  Copy full SHA for 9229863

• zebra: do not set FIB flag on nhg's duplicated nexthops

  Show description for 5ccb711
  pguibert6WIND

  committed
  5ccb711

  Copy full SHA for 5ccb711

• zebra: fix update nhg's nexthop FIB flag when skipping route install

  Show description for 6bca5a3
  pguibert6WIND

  committed
  6bca5a3

  Copy full SHA for 6bca5a3

• zebra: update nexthop flags values when route with nhg is added

  Show description for 601e9e3
  pguibert6WIND

  committed
  601e9e3

  Copy full SHA for 601e9e3

• zebra: update nexthop flags values when route with nhg is updated

  Show description for 984a24b
  pguibert6WIND

  committed
  984a24b

  Copy full SHA for 984a24b

• topotests: all_protocol_startup, add duplicate nexthop-group test

  Show description for 581358b
  pguibert6WIND

  committed
  581358b

  Copy full SHA for 581358b

• zebra: add list of prefixes attached to protocol nhg

  Show description for fddafc7
  pguibert6WIND

  committed
  fddafc7

  Copy full SHA for fddafc7

• zebra: add prefix evaluation at NHG updates

  Show description for b0cca6a
  pguibert6WIND

  committed
  b0cca6a

  Copy full SHA for b0cca6a

• zebra: add nexthop-group prefix-list in show command

  Show description for 4d3c66b
  pguibert6WIND

  committed
  4d3c66b

  Copy full SHA for 4d3c66b

• zebra: mark the active flag of nexthop in a separate function

  Show description for 459095e
  pguibert6WIND

  committed
  459095e

  Copy full SHA for 459095e

• zebra: create nhg_hash_entry on a separate function

  Show description for 4a84a5c
  pguibert6WIND

  committed
  4a84a5c

  Copy full SHA for 4a84a5c

• zebra: reuse old nhe when only recursive nexthops changed

  Show description for 1cf1157
  pguibert6WIND

  committed
  1cf1157

  Copy full SHA for 1cf1157

• topotests: add nexthop group common library

  Show description for 4a48a5a
  pguibert6WIND

  committed
  4a48a5a

  Copy full SHA for 4a48a5a

• topotests: add sharp_recursive_nexthop test

  Show description for d6e9269
  pguibert6WIND

  committed
  d6e9269

  Copy full SHA for d6e9269

• bgpd: add 'debug bgp nexthop-group' command

  Show description for 68c68d4
  pguibert6WIND

  committed
  68c68d4

  Copy full SHA for 68c68d4

• bgpd: add 'bgp nexthop-group' command

  Show description for 3fd2ca7
  pguibert6WIND

  committed
  3fd2ca7

  Copy full SHA for 3fd2ca7

• bgpd: rework bgp_debug_zebra_nh() function

  Show description for a8cdd9c
  pguibert6WIND

  committed
  a8cdd9c

  Copy full SHA for a8cdd9c

• bgpd: add nexthop group framework for l3 routes.

  Show description for 2053ce9
  pguibert6WIND

  committed
  2053ce9

  Copy full SHA for 2053ce9

• bgpd: add zapi messaging for bgp nexthop groups.

  Show description for b941e93
  pguibert6WIND

  committed
  b941e93

  Copy full SHA for b941e93

• bgpd: add nexthop group identifier to each bgp path

  Show description for 3129743
  pguibert6WIND

  committed
  3129743

  Copy full SHA for 3129743

• bgpd: add nexthop tracking support for nexthop-groups

  Show description for 7a1bcf1
  pguibert6WIND

  committed
  7a1bcf1

  Copy full SHA for 7a1bcf1

• bgpd: do not use nhg when prefix resolves over default route or itself

  Show description for d288f8e
  pguibert6WIND

  committed
  d288f8e

  Copy full SHA for d288f8e

• topotests: add bgp_nhg_topo1 test

  Show description for 0fb01c6
  pguibert6WIND

  committed
  0fb01c6

  Copy full SHA for 0fb01c6

• bgpd: move bgp_path_display code from bgp_nexthop.c to bgpd.c

  Show description for 4d7c5b4
  pguibert6WIND

  committed
  4d7c5b4

  Copy full SHA for 4d7c5b4

• bgpd: add 'show bgp nhg' command

  Show description for 961dc17
  pguibert6WIND

  committed
  961dc17

  Copy full SHA for 961dc17

• bgpd: add the bgp_nhg_connected structure and API

  Show description for e997ba3
  pguibert6WIND

  committed
  e997ba3

  Copy full SHA for e997ba3

• bgpd: move bgp nhg_cache nexthop information into nexthops

  Show description for 90d4d65
  pguibert6WIND

  committed
  90d4d65

  Copy full SHA for 90d4d65

• bgpd: rework detail part of show_bgp_nhg_id_helper() function

  Show description for fcbba6e
  pguibert6WIND

  committed
  fcbba6e

  Copy full SHA for fcbba6e

• bgpd: add a parent nhg hash-list ordered by id

  Show description for 06dd256
  pguibert6WIND

  committed
  06dd256

  Copy full SHA for 06dd256

• bgpd: extend the bgp_nhg_cache parent group API

  Show description for d005569
  pguibert6WIND

  committed
  d005569

  Copy full SHA for d005569

• bgpd: add bgp_nhg_nexthop attribute in bgp_path_info

  Show description for 4f54c0a
  pguibert6WIND

  committed
  4f54c0a

  Copy full SHA for 4f54c0a

• bgpd: add nhg group support for multiple path routes

  Show description for 395a027
  pguibert6WIND

  committed
  395a027

  Copy full SHA for 395a027

• bgpd: handle the bgp failover events in BGP nexthop-groups

  Show description for d844bb4
  pguibert6WIND

  committed
  d844bb4

  Copy full SHA for d844bb4

• bgpd: add display of nexthop-group hierarchy

  Show description for 8f64478
  pguibert6WIND

  committed
  8f64478

  Copy full SHA for 8f64478

• bgpd: link all path entries to parent bgp_nhg

  Show description for 1b8cfa5
  pguibert6WIND

  committed
  1b8cfa5

  Copy full SHA for 1b8cfa5

• bgpd: prevent from sending useless ROUTE_ADD messages when NHG is used

  Show description for 9bb3f46
  pguibert6WIND

  committed
  9bb3f46

  Copy full SHA for 9bb3f46

• bgpd: add support for nexthop counter per peer

  Show description for b48be53
  pguibert6WIND

  committed
  b48be53

  Copy full SHA for b48be53

• doc: add bgp user documentation about nexthop-group

  Show description for 2c59ac3
  pguibert6WIND

  committed
  2c59ac3

  Copy full SHA for 2c59ac3

• doc: add technical information about bgp nexthop-groups

  Show description for 414998c
  pguibert6WIND

  committed
  414998c

  Copy full SHA for 414998c

• topotests: bgp_nhg_zapi_scalability, add route update avoidance

  Show description for 54650e2
  pguibert6WIND

  committed
  54650e2

  Copy full SHA for 54650e2

• topotests: bgp_nhg_topo2, add test to check for bgp nhg cases

  Show description for a7224b6
  pguibert6WIND

  committed
  a7224b6

  Copy full SHA for a7224b6

• topotests: bgp_peer_type_multipath, fix test checks 1 active nexthop

  Show description for b914c94
  pguibert6WIND

  committed
  b914c94

  Copy full SHA for b914c94

• topotests: bgp_nhg_zapi_scalability, test recursive routes

  Show description for 85ae24d
  pguibert6WIND

  committed
  85ae24d

  Copy full SHA for 85ae24d

• topotests: bgp_nhg_topo1, move utility function to lib part

  Show description for 898ec0f
  pguibert6WIND

  committed
  898ec0f

  Copy full SHA for 898ec0f

• topotests: bgp_nhg_topo1, add multiple path tests

  Show description for 2f9b4ac
  pguibert6WIND

  committed
  2f9b4ac

  Copy full SHA for 2f9b4ac

• topotests: bgp_nhg_topo2, fix 6pe option not present

  Show description for 06e4905
  pguibert6WIND

  committed
  06e4905

  Copy full SHA for 06e4905

• topotests: add bgp_nhg_zapi_scalability ebgp test

  Show description for af27463
  pguibert6WIND

  committed
  af27463

  Copy full SHA for af27463