ldpd, lib: integrate lde/ldpe into standard logging infrastructure #15515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eqvinox
force-pushed
the
zlog-recirculate-ldpd
branch
from
72c9501 to
4789d82
Compare
This is primarily intended for ldpd with its split-process architecture. The LDE/LDPE subprocesses currently lose the extended zlog functionality. The zlog_live target already encapsulates all necessary bits for vtysh. Reuse it for a relay function to be used in the main ldpd process. Signed-off-by: David Lamparter <[email protected]>
This way, full functionality of `zlog_*` is available. Having `fatal()` be wrappers around `assertf()` also means we get backtraces, which is not the case for a plain `exit(1)`. Signed-off-by: David Lamparter <[email protected]>
eqvinox
force-pushed
the
zlog-recirculate-ldpd
branch
from
4789d82 to
95a737e
Compare
|
Once CI finishes I will push in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lde/ldpe subprocesses previously used ldp-only
IMSG_LOGmessages between lde/ldpe and the main ldpd process, which then threw the messages intozlog_*. This has the unfortunate side effect of losing the unique ID information, but also thatassert()s don't get consistent backtraces, and debug messages are not batched for efficiency.⇒ rework by using the
zlog_livelog target that is already used fordaemon⇒vtyshlog messages by adding a receiver in ldpd so we can dodaemon⇒daemonldpd/log.cis now no longer necessary & entirely removed. UIDs work, asserts get backtraces, and debug messages are batched.Note
ldpduses its original BSD coding style, any style warnings inldpd/*are bogus.