Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add debugs for interface lib module events #15522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Mar 11, 2024

Add some debugs for interface lib events, similar to what is present with "debug vrf".

Copy link
Contributor

@idryzhov idryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/if.c is fully converted to NB, I don't think we should add new functionality using regular non-NB vty anymore.

@mjstapp
Copy link
Contributor Author

mjstapp commented Mar 12, 2024

quite right - updated with a yang model change.

lib/if.c is fully converted to NB, I don't think we should add new functionality using regular non-NB vty anymore.

@mjstapp mjstapp requested a review from idryzhov March 12, 2024 20:31
@idryzhov
Copy link
Contributor

idryzhov commented Apr 1, 2024

I wanted to provide some example of how I think debug should be implemented in NB/mgmtd, but unfortunately it's not possible to implement it before #15594 is merged (RPCs are necessary for temporary debug settings from the "enable" node).

For now I opened a PR #15646 that simplifies the debug module in frrlib and makes it easier to use. As NB can't be implemented properly right now, I'm fine with this PR without NB if it starts using the libfrr debug.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

Mark Stapp added 2 commits January 15, 2025 10:46
Add debugs to the interface library, and to a couple of zebra
interface- and vrf-message apis.

Signed-off-by: Mark Stapp <[email protected]>
Add cli, handlers, and yang model for 'debug interface'. This was
a little awkward; had to put the actual cli in one lib module and
offer some support apis from the interface module.

Signed-off-by: Mark Stapp <[email protected]>
@mjstapp
Copy link
Contributor Author

mjstapp commented Jan 15, 2025

Updated to newer master; still working on this, still think it's worth ... something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants