-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add debugs for interface lib module events #15522
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/if.c is fully converted to NB, I don't think we should add new functionality using regular non-NB vty anymore.
quite right - updated with a yang model change.
|
I wanted to provide some example of how I think debug should be implemented in NB/mgmtd, but unfortunately it's not possible to implement it before #15594 is merged (RPCs are necessary for temporary debug settings from the "enable" node). For now I opened a PR #15646 that simplifies the debug module in frrlib and makes it easier to use. As NB can't be implemented properly right now, I'm fine with this PR without NB if it starts using the libfrr debug. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR is stale because it has been open 180 days with no activity. Comment or remove the |
Add debugs to the interface library, and to a couple of zebra interface- and vrf-message apis. Signed-off-by: Mark Stapp <[email protected]>
Add cli, handlers, and yang model for 'debug interface'. This was a little awkward; had to put the actual cli in one lib module and offer some support apis from the interface module. Signed-off-by: Mark Stapp <[email protected]>
Updated to newer master; still working on this, still think it's worth ... something |
Add some debugs for interface lib events, similar to what is present with "debug vrf".