bgpd: Add tests for Paths-Limit capability #15533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
force-pushed
the
fix/add_paths_limit_capability_test
branch
from
0e61e83 to
4f09d78
Compare
ton31337
force-pushed
the
fix/add_paths_limit_capability_test
branch
from
4f09d78 to
5a791c3
Compare
It's very annoying when testing and instead of looking for true/false, you have to check if the field exists. Signed-off-by: Donatas Abraitis <[email protected]>
The capability should be untouched, and send 0 (unlimited) instead. Otherwise, we miss the capability and things are broken later until the session reset. Fixes: 72f0e06 ("bgpd: Implement Paths-Limit capability") Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/add_paths_limit_capability_test
branch
from
5a791c3 to
6ff16b3
Compare
When sending the packets over the network (dynamic capability) it reports 6 bytes instead of 5 bytes, and causes some issues between little/big endian machines. Signed-off-by: Donatas Abraitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.