Zebra rtadv use without init #15582
Merged
Zebra rtadv use without init #15582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
donaldsharp
commented
Mar 20, 2024
donaldsharp
commented
- Ensure that generate_support_bundles doesn't crash the run
- Cleanup a sendmsg call that sent down uninited data.
|
LGTM : I am surprised that gcc/clang did not yell about it. |
|
it does. We are not compiling in CI with --enable-werror as we should at this point in time. Something we have been working towards. |
ton31337
reviewed
Mar 20, 2024
tests/topotests/lib/common_config.py
Outdated
| @@ -936,14 +936,26 @@ def generate_support_bundle(): | |||
| """ | |||
|
|
|||
| tgen = get_topogen() | |||
| if tgen is None: | |||
| logger.info( | |||
tests/topotests/lib/common_config.py
Outdated
| ) | ||
| rnode.run("mkdir -p " + dst_bundle) | ||
| except Exception as err: | ||
| logger.info("Generation of Support bundle failed {}".format(err)) |
There was a problem hiding this comment.
Probably this should be logger.error()?
valgrind is complaining about this problem. This fixes it. Signed-off-by: Donald Sharp <[email protected]>
The Support bundle generation was/is failing in both our upstream ci and locally. This cleans up the failures that I am seeing such that tests now continue to run instead of aborting the test run. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
zebra_rtadv_use_without_init
branch
from
fdd4db7 to
ea570f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.