ospfd: Assure OSPF AS External routes are installed after link flap #15593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aceelindem
force-pushed
the
acee/ospf-link-flap-ase-route-change
branch
from
ab5603f to
f84a1b2
Compare
mjstapp
reviewed
Mar 21, 2024
ospfd/ospf_interface.c
Outdated
| for (rn = route_top(table); rn; rn = route_next(rn)) { | ||
| or = rn->info; | ||
|
|
||
| if (!or) |
There was a problem hiding this comment.
looks like the style-check doesn't like this - how about if (or == NULL) instead?
There was a problem hiding this comment.
Yeah - this is my second iteration as "git-clang-format --diff" suggested "if (! or)" but then that failed one of the platform builds. I'll try this and squash the commit. The funny thing is there are plenty of other null pointer checks in FRR using "!ptr".
Thanks,
Mark
There was a problem hiding this comment.
yes, I know the "pointer as boolean" thing is common; don't know why this particular instance is setting off the CI check.
OSPF intra/inter area routes were previously marked to assure they are re-installed after a fast link flap in the commit: commit effee18 Author: Donald Sharp <[email protected]> Date: Mon May 24 13:45:29 2021 -0400 ospfd: Fix quick interface down up event handling in ospf This commit extends this fix to OSPF AS External routes as well. Signed-off-by: Acee <[email protected]>
aceelindem
force-pushed
the
acee/ospf-link-flap-ase-route-change
branch
from
f84a1b2 to
7ac1994
Compare
|
CI:rerun |
mjstapp
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSPF intra/inter area routes were previously marked to assure they are re-installed after a fast link flap in the commit:
commit effee18
Author: Donald Sharp [email protected]
Date: Mon May 24 13:45:29 2021 -0400
This commit extends this fix to OSPF AS External routes as well.