Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Do not convert to ipv6 mapped address if it was modified by route-map #15611

Conversation

ton31337
Copy link
Member

No description provided.

…te-map

Fixes 0325116 ("bgpd: fix 6vpe nexthop")

Signed-off-by: Donatas Abraitis <[email protected]>
@bbs2web
Copy link

bbs2web commented Mar 24, 2024

I'm very gratefull! I'll make some time to take notes on how to recompile FRR in VyOS.

Please ignore my ignorance, but wouldn't it perhaps not be better to change behaviour to not override the next-hop when 'attribute-unchanged next-hop' is set on a peer?

Our problem with the suggested patch is that the outgoing policy wouldn't know what each prefix's gateway should be, each provider edge router sets this when the prefix is announced to the route reflector.

Replacing the prefix's next hop with the route reflector's IPv4 encoded as IPv6 on iBGP route reflector sessions should IMHO be an option, to either disable or enable the behaviour, depending on the default.

@ton31337
Copy link
Member Author

I was thinking if incoming or outgoing RMAP is used to change the next hop, then ignore the mapping. Other than that, I'm not much familiar with other edge cases where this might hit also... @louis-6wind do you have an opinion here?

@ton31337 ton31337 requested a review from louis-6wind March 24, 2024 16:38
@riw777 riw777 self-requested a review March 26, 2024 14:33
@donaldsharp donaldsharp self-requested a review April 2, 2024 15:40
@louis-6wind
Copy link
Contributor

louis-6wind commented Apr 8, 2024

Shall we continue in #15614 ?

@ton31337
Copy link
Member Author

ton31337 commented Apr 8, 2024

Sure.

@ton31337 ton31337 closed this Apr 8, 2024
@ton31337 ton31337 deleted the fix/do_not_convert_to_mapped branch April 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants