topotests: fix ignore routes with linkdown #15633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryzhov
requested changes
Apr 3, 2024
In topotest, a given interface has only the ignore routes bit turned on for IPv6 only, whereas topotest is expected to turn it on for all address families. > # show interface > Interface r2-r3-eth2 is up, line protocol is up > [..] > flags: <UP,BROADCAST,RUNNING,MULTICAST> > Ignore all v6 routes with linkdown > Type: Ethernet > [..] This is because the only the 'default' ipv6 ignore sysctl is set to 1. Set also the /proc/sys/net/conf/<family>/default/ignore_routes_with_linkdown flag, to have same behaviour for ipv4 and ipv6. Fixes: 4958158 ("tests: micronet: update infra") Signed-off-by: Philippe Guibert <[email protected]>
The |
pguibert6WIND
force-pushed
the
ipv4_ignore_routes_with_linkdown
branch
from
cefebd8 to
c2e0060
Compare
idryzhov
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In topotest, a given interface has only the ignore routes bit turned on for IPv6 only, whereas topotest is expected to turn it on for all address families.
This is because the only the 'default' ipv6 ignore sysctl is set to
Fixes: 4958158 ("tests: micronet: update infra")