Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospf6d: OSPFv3 manual key authentication neglects checking the SA ID. #16163

Conversation

aceelindem
Copy link
Collaborator

Also, add topotest variation to verify checking.

This corrects https://github.com/FRRouting/frr/issues/16100.

    Also, add topotest variation to verify checking.

    This corrects FRRouting#16100.

Signed-off-by: Acee Lindem <[email protected]>
@aceelindem
Copy link
Collaborator Author

Also, tested my debug message manually:

2024/06/04 21:44:25 OSPF6: [PRS2G-YQ2G0] RECV[r1-r2-eth1]: Auth SA ID mismatch for Hello, received 30 vs configured 10
2024/06/04 21:44:25 OSPF6: [ZN6JB-XGJFW] RECV[r1-r2-eth1]: OSPF packet auth digest miss-match on Hello
2024/06/04 21:44:26 OSPF6: [PRS2G-YQ2G0] RECV[r1-r2-eth1]: Auth SA ID mismatch for LSAck, received 30 vs configured 10
2024/06/04 21:44:26 OSPF6: [ZN6JB-XGJFW] RECV[r1-r2-eth1]: OSPF packet auth digest miss-match on LSAck

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donaldsharp donaldsharp merged commit 36bb593 into FRRouting:master Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants