isis_tilfa_topo1 rework #16187
Merged
isis_tilfa_topo1 rework #16187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwestphal -> please rebase and force push. This will bring in the fix for the failed test. |
In this topotest, steps 10-15 were added to test the IS-IS switchover functionality. In short, two cases were tested: switchover after a link down event and switchover after a BFD down event. Both cases were tested in sequence on the same router, rt6. This involved the following steps: - Setting the SPF delay timer to 15 seconds - Shutting down the eth-rt5 interface from the switch side - Testing the post-switchover RIB and LIB (triggered by the link down event) - Testing the post-SPF RIB and LIB - Bringing the eth-rt5 interface back up - Configuring a BFD session between rt6 and rt5 - Shutting down the eth-rt5 interface from the switch side once again - Testing the post-switchover RIB and LIB (triggered by the BFD down event) - Testing the post-SPF RIB and LIB Since the time window to test the post-switchover RIB and LIB was too narrow (10 seconds), these tests were having sporadic failures. To resolve this problem, we can simplify the switchover test as follows: - Setting the SPF delay timer to 60 seconds (not 15) - Disabling "link-detect" on rt6's eth-rt5 interface - Shutting down the eth-rt5 interface from the switch side - On rt6, testing the post-switchover RIB and LIB (triggered by the BFD down event) - On rt5, testing the post-switchover RIB and LIB (triggered by the link down event) Notice how we can test both post-link-down and post-BFD-down switchover cases simultaneously by having different "link-detect" configurations on rt5 and rt6. Additionally, by using a larger SPF delay timer, the time window to test the post-switchover RIB and LIB is much larger and less prone to sporadic failures. Signed-off-by: Renato Westphal <[email protected]>
The isis_tilfa_topo1 topotest is comprehensive and contains a large amount of reference data. One problem is that, when changes occur, updating this reference data can be difficult. To address this problem, this commit introduces a method to automatically regenerate the reference data by setting the `REGEN_DATA` environment variable. Usage: $ REGEN_DATA=true python3 ./test_isis_tilfa_topo1.py When `REGEN_DATA` is set, the topotest regenerates reference data from the current run instead of comparing against existing reference data. Note that regenerated data must be manually verified for correctness. This commit also simplifies the reference data by replacing all diff files with complete JSON snapshots. Signed-off-by: Renato Westphal <[email protected]>
rwestphal
force-pushed
the
isis_tilfa_topo_rework
branch
from
c5b8325 to
dc354cb
Compare
@donaldsharp Done 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
REGEN_DATA=true python3 ./test_isis_tilfa_topo1.pyPlease see the commit messages for details.
Fixes #15704