isisd: Three-Way Handshake State Change from Expiring

[beith12]

Under certain conditions the ISIS three-way handshake becomes stuck in an 'Expiring' mode and does not clear the neighbor entry. This fix will clear the neighbor entry if this condition becomes true.

[riw777]

looks good

[aceelindem]

Fix looks reasonable to handle this adjacency state as well. Why doesn't it also apply to broadcast circuits?

[beith12]

@aceelindem Valid point - I can do another commit for the Broadcast circuit type.

[riw777]

I'm okay with a separate commit for broadcast type ... should we open an issue to track it?

[aceelindem]

Looks good. Normally, you'd squash the two commits though.

[aceelindem]

I'm okay with a separate commit for broadcast type ... should we open an issue to track it?

I'm okay if you are. Do we need issues for every fix? I haven't been opening them.

[riw777]

Looks good. Normally, you'd squash the two commits though.

I'm okay with a separate commit for broadcast type ... should we open an issue to track it?

I'm okay if you are. Do we need issues for every fix? I haven't been opening them.

nah ... just don't want to forget this additional work needs to be done ...

[aceelindem]

Looks good. Normally, you'd squash the two commits though.

I'm okay with a separate commit for broadcast type ... should we open an issue to track it?

I'm okay if you are. Do we need issues for every fix? I haven't been opening them.

nah ... just don't want to forget this additional work needs to be done ...

Looks good. Normally, you'd squash the two commits though.

I'm okay with a separate commit for broadcast type ... should we open an issue to track it?

I'm okay if you are. Do we need issues for every fix? I haven't been opening them.

nah ... just don't want to forget this additional work needs to be done ...

The second commit commit handles the broadcast circuit. It is just not squashed - which I agree is ok.

[riw777]

please fix the lints, and then we can try to figure the failures out ... thanks!

[beith12]

Thanks @riw777 - style now corrected

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[riw777]

failing in ospf single switch test ... reunning just the failure to see if we can clear this

[aceelindem]

failing in ospf single switch test ... reunning just the failure to see if we can clear this

I've seen this failure on PRs as well - I think it is related to the topotest using 8 routers.

[riw777]

please rebase to and let's see if that fixes this ci failure
we also need to clear the conflicts now ... :-(

[beith12]

When i did the rebase i got a conflict and found that a previous commit has actually dealt with this same issue.

5009f75

[riw777]

it seems like we should close this one then?

@frrbot autoclose in 1 month