tests, zebra: rename nexthop-group depends dependends #16251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hierarchy between next-hop groups in the "show nexthop-group rib" output can be challenging to understand. The terms "depends" and "dependents" refer to child and parent next-hop groups, respectively. > r1# show nexthop-group rib 181818168 > ID: 181818168 (sharp) > RefCnt: 1 > Uptime: 00:06:42 > VRF: default > Depends: (96) (97) > via 1.1.1.1 (vrf default) inactive, weight 1 > via 1.1.1.2 (vrf default) inactive, weight 1 > r1# show nexthop-group rib 96 > ID: 96 (sharp) > RefCnt: 2 > Uptime: 00:06:59 > VRF: default > via 1.1.1.1 (vrf default) inactive, weight 1 > Dependents: (181818168) Rename "Depends" and "Dependents" to child and parent. > r1# show nexthop-group rib 181818168 > ID: 181818168 (sharp) > RefCnt: 1 > Uptime: 00:06:42 > VRF: default > Child groups: (96) (97) > via 1.1.1.1 (vrf default) inactive, weight 1 > via 1.1.1.2 (vrf default) inactive, weight 1 > r1# show nexthop-group rib 96 > ID: 96 (sharp) > RefCnt: 2 > Uptime: 00:06:59 > VRF: default > via 1.1.1.1 (vrf default) inactive, weight 1 > Parent groups: (181818168) Signed-off-by: Louis Scalbert <[email protected]>
Clarify naming using: > git grep nhg_dependents | cut -f1 -d: |xargs -L1 sed -e 's|nhg_dependents|nhg_parent|g' -i Signed-off-by: Louis Scalbert <[email protected]>
Clarify naming using: > it grep nhg_depends | cut -f1 -d: |xargs -L1 sed -e 's|nhg_depends|nhg_child|g' -i Signed-off-by: Louis Scalbert <[email protected]>
> sed -e 's|dependent|parent|g' -i zebra/zebra_nhg.h > sed -e 's|dependent|parent|g' -i zebra/zebra_nhg.c Signed-off-by: Louis Scalbert <[email protected]>
Apply: > sed -e 's|depends_|child_|g;s|\<depend\>|child|g' -i zebra/zebra_nhg.c And rename depends to child or children in zebra_nhg Signed-off-by: Louis Scalbert <[email protected]>
> sed -e 's|depends|chidren|g;s|depend|child|g' -i tests/topotests/all_protocol_startup/test_all_protocol_startup.py Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
rename-depends
branch
from
5dc9880 to
80b1d93
Compare
mjstapp
reviewed
Jun 20, 2024
IMO, the code is also confusing |
|
ci:rerun |
|
No, this just doesn't make sense to me. it's too bad that you find the code confusing - it is complicated. but renaming some things isn't going to make it any easier to understand. if we diverge from the existing released branches, we'll have ongoing trouble backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hierarchy between next-hop groups in the "show nexthop-group rib"
output can be challenging to understand. The terms "depends" and
"dependents" refer to child and parent next-hop groups, respectively.
Rename "Depends" and "Dependents" to child and parent.
Also rename the code