ospfd: fix state location mixup #16361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the "2x2 matrix" of these, I accidentally edited "row-wise" when I should've edited "column-wise"... *sigh* Reported-by: github.com/rbfnet Fixes: FRRouting#16349 Fixes: 110945b ("ospfd: fix GR state location") Signed-off-by: David Lamparter <[email protected]>
aceelindem
reviewed
Jul 10, 2024
|
|
||
| /* this one includes the path... because the instance number was in the path | ||
| * before :( ... which totally didn't have a mkdir anywhere. | ||
| * |
There was a problem hiding this comment.
I don't see problems with the C logic but I'd rather see a comment explaining the usage and rationale behind the various paths. Your comment as written seems only useful in the context of what you are changing as opposed to what paths are created and what they are to be used for.
There was a problem hiding this comment.
done (but I've put it in lib/libfrr.h because the variables are declared there & used beyond ospfd)
It's not immediately obvious what exactly the `frr_*dir` variables exported from lib/libfrr.c are for. Add a little text each to clarify. Signed-off-by: David Lamparter <[email protected]>
aceelindem
approved these changes
Jul 11, 2024
| OSPFD_COMPAT_STATE_NAME); | ||
| /* no COMPAT2 here since it was reading that was broken, |
There was a problem hiding this comment.
What does "it was reading that was broken" mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "2x2 matrix" of these, I accidentally edited "row-wise" when I should've edited "column-wise"... sigh
Reported-by: @rbfnet
Fixes: #16349
Fixes: 110945b ("ospfd: fix GR state location")